New theme; Any interest?

General discussion about netjukebox
godsyn
User
Posts: 11
Joined: Thu Apr 19, 2012 8:10 am

Re: New theme; Any interest?

Post by godsyn » Thu May 17, 2012 5:43 pm

Implemented without issues.
Thanks!

User avatar
wbartels
netjukebox developer
Posts: 792
Joined: Thu Nov 04, 2004 3:12 pm
Location: Netherlands
Contact:

Re: New theme; Any interest?

Post by wbartels » Sat May 19, 2012 1:02 am

With the example code it is not possible to load other skins than the default skin.
I have fixed this bug and some other improvements in netjukebox 5.37.
netjukebox 5.37 will be released this weekend.

Than I will take a break with programming :wink:

User avatar
wbartels
netjukebox developer
Posts: 792
Joined: Thu Nov 04, 2004 3:12 pm
Location: Netherlands
Contact:

Re: New theme; Any interest?

Post by wbartels » Mon Jun 04, 2012 12:44 am

godsyn wrote:Best of both worlds, I'll start work on defining text via css for menus/icons/etc. For example:
Instead of: <a href="favorite.php">favorites</a>
use
<a id="mainmenu-favorites" href="favorite.php"></a>
and in css use:
#mainmenu-favorites{
background-image:url('/path/tp/favorites.png');
}
OR
#mainmenu-favorites:before{
content:'Music I like';
}
Allowing for text, an image, or translations.

Thoughts?
It can be done the other way around.
Just add the text to the href like:

Code: Select all

<ul id="main_menu">
	<li><a href="index.php" class="media<?php echo ($cfg['menu'] == 'media') ? '_on' : ''; ?>">Media</a></li>
	<li><a href="favorite.php" class="favorites<?php echo ($cfg['menu'] == 'favorite') ? '_on' : ''; ?>">Favorites</a></li>
	<li><a href="playlist.php" class="playlist<?php echo ($cfg['menu'] == 'playlist') ? '_on' : ''; ?>">Playlist</a></li>
	<li><a href="config.php" class="config<?php echo ($cfg['menu'] == 'config') ? '_on' : ''; ?>">Config</a></li>
</ul>
And when needed it can be removed in the stylesheet:

Code: Select all

#main_menu li a {
	...
	text-indent: -1000px;
}

User avatar
wbartels
netjukebox developer
Posts: 792
Joined: Thu Nov 04, 2004 3:12 pm
Location: Netherlands
Contact:

Re: New theme; Any interest?

Post by wbartels » Sun Jun 10, 2012 9:13 am

godsyn wrote:I've started working on removing the nested tables (yuck) and pointless back-ground images (eg: gradient) and converting everything to CSS. The theme's name is HTML5Clean, and short of some issues with embedded images (eg: DIVs/tables not defined by the theme), I've removed all background images, cleaned up the css, and ensured it is cross browser compatible. Would someone be willing to clean it up some more? The player is looking a little rough due to base (non-theme-able) code not being html5 compliant.
I'm planning to rewrite netjukebox and get ride of almost all tables.
Still I will use tables for tabular data where columns are needed.
I'm planning to use the ul li structure for: menu, submenu, (breadcrumb) navigator & footer (maybe login, etc...).

Thanks for the inspiration and for examples I will often look to your code!!

Post Reply